Skip to content

Fix issue 14892: Inconsistent nullPointerOutOfResources after possible noreturn function#8700

Open
pfultz2 wants to merge 4 commits into
cppcheck-opensource:mainfrom
pfultz2:valueflow-unknown-noreturn-inconclusive
Open

Fix issue 14892: Inconsistent nullPointerOutOfResources after possible noreturn function#8700
pfultz2 wants to merge 4 commits into
cppcheck-opensource:mainfrom
pfultz2:valueflow-unknown-noreturn-inconclusive

Conversation

@pfultz2

@pfultz2 pfultz2 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 6, 2026
View reviewed changes
Comment thread lib/forwardanalyzer.cpp
{
// The condition is only "known" because of an earlier assumption, so the
// skipped block could still modify the value -> lower to possible
if (!condTok->hasKnownIntValue() && skippedBlock && analyzeScope(skippedBlock).isModified() &&
Comment thread lib/forwardanalyzer.cpp
analyzer->updateState(ctx);
}

Progress updateScope(Token* endBlock, int depth = 20)
@chrchr-github

chrchr-github commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

We now show an inconclusive warning in all cases when there is a possible noreturn function, right? Can we somehow point to that function to explain why the warning is inconclusive?

@pfultz2

pfultz2 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

We now show an inconclusive warning in all cases when there is a possible noreturn function, right? Can we somehow point to that function to explain why the warning is inconclusive?

Are you wanting that in the Value's error log? Or just a debug logging?

I can add it to the Value's error log in the ConditionHandler with a little refactoring, but adding it to the error log in the ForwardAnalyzer would require a lot more work as we need to update the interface to attach an error log.

@chrchr-github

chrchr-github commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Are you wanting that in the Value's error log? Or just a debug logging?

I can add it to the Value's error log in the ConditionHandler with a little refactoring, but adding it to the error log in the ForwardAnalyzer would require a lot more work as we need to update the interface to attach an error log.

It would be helpful to give a hint to the user why the warning is inconclusive. That might be out of scope for this PR though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pfultz2 @chrchr-github @github-advanced-security